Add a kSimd128 machine type for Turbofan.

Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.
Adds UntaggedSimd128 to types.h.

LOG=N
BUG=v8:4124
Committed: https://crrev.com/6b6b005feb5e84969488bcb45e3f4eb56b4600e2
Cr-Commit-Position: refs/heads/master@{#34089}

[bbudge, 2016-02-13 01:38:27]

Description was changed from

==========
Add a kSimd128 machine type for Turbofan.

LOG=N
BUG=v8:4124
==========

to

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.


LOG=N
BUG=v8:4124
==========

[bbudge, 2016-02-13 01:40:41]

Description was changed from

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.


LOG=N
BUG=v8:4124
==========

to

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.
Adds UntaggedSimd128 to types.h.

LOG=N
BUG=v8:4124
==========

[bbudge, 2016-02-16 04:43:49]

bbudge@chromium.org changed reviewers:
+ titzer@chromium.org

[bbudge, 2016-02-16 04:43:50]

Reroute to appropriate reviewer if necessary.
This seems like a good size CL for review. The next step is to add
representation changes and lowering for tagged and untagged values.

[titzer, 2016-02-17 11:57:02]

titzer@chromium.org changed reviewers:
+ jarin@chromium.org

[titzer, 2016-02-17 11:57:02]

This is mostly mechanical, so looks mostly fine. Adding +jarin for
SimplifiedLowering changes.

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
src/compiler/x64/instruction-selector-x64.cc:134: case
MachineRepresentation::kSimd128:
Probably want to make this case unreachable for now, since movq is only 8 bytes.

[Jarin, 2016-02-17 12:06:47]

lgtm with nits.

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/representa...
File src/compiler/representation-change.cc (right):

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/representa...
src/compiler/representation-change.cc:150: // TODO(bbudge) Handle conversions
between tagged and untagged.
Until then, could you DCHECK(output_rep == kSimd128)? (Or just "break;" because
we should not try to convert to the same representation.)

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
src/compiler/x64/instruction-selector-x64.cc:221: case
MachineRepresentation::kSimd128:
Preferably move this case to the unreachable case, movq seems wrong.

[bbudge, 2016-02-17 18:28:52]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2016-02-17 18:28:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1693963004/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-02-17 18:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693963004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693963004/80001

[bbudge, 2016-02-17 18:57:15]

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/representa...
File src/compiler/representation-change.cc (right):

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/representa...
src/compiler/representation-change.cc:150: // TODO(bbudge) Handle conversions
between tagged and untagged.
On 2016/02/17 12:06:46, Jarin wrote:
> Until then, could you DCHECK(output_rep == kSimd128)? (Or just "break;"
because
> we should not try to convert to the same representation.)

break seems right here. Done.

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
File src/compiler/x64/instruction-selector-x64.cc (right):

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
src/compiler/x64/instruction-selector-x64.cc:134: case
MachineRepresentation::kSimd128:
On 2016/02/17 11:57:02, titzer wrote:
> Probably want to make this case unreachable for now, since movq is only 8
bytes.

Done.

https://codereview.chromium.org/1693963004/diff/40001/src/compiler/x64/instru...
src/compiler/x64/instruction-selector-x64.cc:221: case
MachineRepresentation::kSimd128:
On 2016/02/17 12:06:47, Jarin wrote:
> Preferably move this case to the unreachable case, movq seems wrong.

Done.

[commit-bot: I haz the power, 2016-02-17 19:03:50]

Description was changed from

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.
Adds UntaggedSimd128 to types.h.

LOG=N
BUG=v8:4124
==========

to

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.
Adds UntaggedSimd128 to types.h.

LOG=N
BUG=v8:4124
==========

[commit-bot: I haz the power, 2016-02-17 19:03:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-17 19:04:38]

Description was changed from

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.
Adds UntaggedSimd128 to types.h.

LOG=N
BUG=v8:4124
==========

to

==========
Add a kSimd128 machine type for Turbofan.

Adds kSimd128 to MachineRepresentation.
Adds a Simd128Register concept that's platform independent.
Adds UntaggedSimd128 to types.h.

LOG=N
BUG=v8:4124

Committed: https://crrev.com/6b6b005feb5e84969488bcb45e3f4eb56b4600e2
Cr-Commit-Position: refs/heads/master@{#34089}
==========

[commit-bot: I haz the power, 2016-02-17 19:04:40]

Patchset 5 (id:??) landed as
https://crrev.com/6b6b005feb5e84969488bcb45e3f4eb56b4600e2
Cr-Commit-Position: refs/heads/master@{#34089}