ui/app_list/views/search_box_view.cc - Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/search_box_view.cc

Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed one call to SendFocusAlert Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc ('k') | ui/app_list/views/search_result_list_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/app_list/views/search_box_view.cc

diff --git a/ui/app_list/views/search_box_view.cc b/ui/app_list/views/search_box_view.cc

index 1441d6c1631e14a3c6a56005577f7a9182f2b38c..cf76db6c8482079729db22ef9d6e6d8be3c06a8f 100644

--- a/ui/app_list/views/search_box_view.cc

+++ b/ui/app_list/views/search_box_view.cc

@@ -88,7 +88,7 @@ class SearchBoxImageButton : public views::ImageButton {

selected_ = selected;

SchedulePaint();

if (selected)

- NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, true);

+ NotifyAccessibilityEvent(ui::AX_EVENT_SELECTION, true);

}

bool OnKeyPressed(const ui::KeyEvent& event) override {