chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc - Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed one call to SendFocusAlert Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js ('k') | ui/app_list/views/search_box_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

diff --git a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

index d4c8f18651130bfbbe9fb5bff8c3ce737cb28330..f8431719ca76c133a24d0bce7b795118dd826911 100644

--- a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

+++ b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

@@ -205,7 +205,7 @@ void PasswordGenerationPopupViewViews::PasswordSelectionUpdated() {

return;

if (controller_->password_selected())

- NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, true);

+ NotifyAccessibilityEvent(ui::AX_EVENT_SELECTION, true);

password_view_->set_background(

views::Background::CreateSolidBackground(