Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1693703002: Revert of Run angle_unittests on swarming. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, Jamie Madill, Geoff Lang, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run angle_unittests on swarming. (patchset #1 id:1 of https://codereview.chromium.org/1690463003/ ) Reason for revert: angle_unittests_run only exists if archive_gpu_tests is set, which means it can't run on the clang/win bots. Reverting to investigate this asynchronously. Original issue's description: > Run angle_unittests on swarming. > > angle_unittests goes through all the motions to run on swarming (isolate file, > angle_unittests_run target, etc), but it doesn't run on swarming anywhere. > Since the test is pretty slow, move it to swarming. > > $ testing/buildbot/manage.py --convert angle_unittests > Convert angle_unittests to run exclusively on Swarming > > 32 configs already ran on Swarming > 31 used to run locally and were converted: > - chromium.angle.json: Linux Tests (ANGLE) > - chromium.angle.json: Linux Tests (dbg) (ANGLE) > - chromium.angle.json: Mac10.8 Tests (ANGLE) > - chromium.angle.json: Mac10.8 Tests (dbg) (ANGLE) > - chromium.angle.json: Win7 Tests (ANGLE) > - chromium.angle.json: Win7 Tests (dbg) (ANGLE) > - chromium.angle.json: Win7 Tests x64 (ANGLE) > - chromium.angle.json: Win7 Tests x64 (dbg) (ANGLE) > - chromium.fyi.json: CFI Linux > - chromium.fyi.json: Chromium Win 10 > - chromium.fyi.json: ClangToTLinux tester > - chromium.fyi.json: ClangToTLinuxASan tester > - chromium.fyi.json: ClangToTLinuxUBSanVptr tester > - chromium.fyi.json: ClangToTMac tester > - chromium.fyi.json: ClangToTMacASan tester > - chromium.fyi.json: ClangToTWin tester > - chromium.fyi.json: ClangToTWin(dbg) tester > - chromium.fyi.json: ClangToTWin(dll) tester > - chromium.fyi.json: ClangToTWin64 tester > - chromium.fyi.json: ClangToTWin64(dbg) tester > - chromium.fyi.json: ClangToTWin64(dll) tester > - chromium.fyi.json: CrWinAsan tester > - chromium.fyi.json: CrWinAsan(dll) tester > - chromium.fyi.json: CrWinAsanCov tester > - chromium.fyi.json: CrWinClang tester > - chromium.fyi.json: CrWinClang(dbg) tester > - chromium.fyi.json: CrWinClang(shared) tester > - chromium.fyi.json: CrWinClang64 tester > - chromium.fyi.json: CrWinClang64(dbg) tester > - chromium.fyi.json: CrWinClang64(dll) tester > - chromium.fyi.json: CrWinClangLLD tester > > Ran: > ./manage.py --convert angle_unittests > > R= > BUG=98637 TBR=kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/2e4ce9994090f2f77eeddec2a504eb7e8608a1bb Cr-Commit-Position: refs/heads/master@{#375093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M testing/buildbot/chromium.angle.json View 8 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 23 chunks +0 lines, -69 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Run angle_unittests on swarming.
4 years, 10 months ago (2016-02-12 02:12:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693703002/1
4 years, 10 months ago (2016-02-12 02:12:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 02:14:31 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:40:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e4ce9994090f2f77eeddec2a504eb7e8608a1bb
Cr-Commit-Position: refs/heads/master@{#375093}

Powered by Google App Engine
This is Rietveld 408576698