third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp - Issue 1693563003: Take Accept-Language into account in CJK font fallback for Android/Win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 1693563003: Take Accept-Language into account in CJK font fallback for Android/Win (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aceept-lang

Patch Set: Fix non-Windows builds Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm ('k') | third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

index 9e2f7619b4f1354be3089543ae8859c1a46f10c1..3945eda37b423ae8eb0132273b12175204acc2d2 100644

--- a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

+++ b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

@@ -112,11 +112,6 @@ FontCache::FontCache()

m_fontManager = adoptPtr(fontManager);

}

-void FontCache::acceptLanguagesChanged(const String&)

- // TODO(kojii): Take acceptLanguages into account for ambiguos scripts.

// Given the desired base font, this will create a SimpleFontData for a specific

// font that can be used to render the given range of characters.

PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(