third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm - Issue 1693563003: Take Accept-Language into account in CJK font fallback for Android/Win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm

Issue 1693563003: Take Accept-Language into account in CJK font fallback for Android/Win (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aceept-lang

Patch Set: Fix non-Windows builds Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp ('k') | third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm

diff --git a/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm b/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm

index 159b06d13701e6a03587a590996a767f72aec3d0..629b7eb5898546dfbd79361cc4096463330f4658 100644

--- a/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm

+++ b/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm

@@ -96,8 +96,6 @@ static inline bool isAppKitFontWeightBold(NSInteger appKitFontWeight)

return appKitFontWeight >= 7;

}

-void FontCache::acceptLanguagesChanged(const String&) {}

PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(const FontDescription& fontDescription, UChar32 character, const SimpleFontData* fontDataToSubstitute)

{

// FIXME: We should fix getFallbackFamily to take a UChar32