content/browser/loader/navigation_url_loader_unittest.cc - Issue 1693563002: PROTOTYPE: PlzNavigate: use a Mojo data pipe to stream navigation data to the renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 1693563002: PROTOTYPE: PlzNavigate: use a Mojo data pipe to stream navigation data to the renderer. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Browser sends URLRequest id to the renderer and renderer uses intermediary buffer for data: none he… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_impl_core.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_unittest.cc

diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc

index 1e32323e0cff695f9aa367b88af2078b9595345b..2495936a1a00472f6bc26f58e84c8b75f98a8a0e 100644

--- a/content/browser/loader/navigation_url_loader_unittest.cc

+++ b/content/browser/loader/navigation_url_loader_unittest.cc

@@ -109,10 +109,13 @@ class TestNavigationURLLoaderDelegate : public NavigationURLLoaderDelegate {

request_redirected_->Quit();

}

- void OnResponseStarted(const scoped_refptr<ResourceResponse>& response,

- scoped_ptr<StreamHandle> body) override {

+ void OnResponseStarted(

+ const scoped_refptr<ResourceResponse>& response,

+ scoped_ptr<StreamHandle> body,

+ mojo::ScopedDataPipeConsumerHandle data_consumer_handle) override {

response_ = response;

body_ = std::move(body);

+ data_consumer_handle_ = std::move(data_consumer_handle);

ASSERT_TRUE(response_started_);

response_started_->Quit();

}

@@ -133,6 +136,7 @@ class TestNavigationURLLoaderDelegate : public NavigationURLLoaderDelegate {

scoped_refptr<ResourceResponse> redirect_response_;

scoped_refptr<ResourceResponse> response_;

scoped_ptr<StreamHandle> body_;

+ mojo::ScopedDataPipeConsumerHandle data_consumer_handle_;

int net_error_;

int on_request_handled_counter_;