content/browser/loader/navigation_url_loader_impl_core.cc - Issue 1693563002: PROTOTYPE: PlzNavigate: use a Mojo data pipe to stream navigation data to the renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_impl_core.cc

Issue 1693563002: PROTOTYPE: PlzNavigate: use a Mojo data pipe to stream navigation data to the renderer. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Browser sends URLRequest id to the renderer and renderer uses intermediary buffer for data: none he… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/navigation_url_loader_impl_core.h ('k') | content/browser/loader/navigation_url_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_impl_core.cc

diff --git a/content/browser/loader/navigation_url_loader_impl_core.cc b/content/browser/loader/navigation_url_loader_impl_core.cc

index bd7ef98f8eaaf69fc862f0ae36eed0ed7c2ea8c2..f6fce38dd803556961f7f062af9470bf7e275919 100644

--- a/content/browser/loader/navigation_url_loader_impl_core.cc

+++ b/content/browser/loader/navigation_url_loader_impl_core.cc

@@ -87,7 +87,8 @@ void NavigationURLLoaderImplCore::NotifyRequestRedirected(

void NavigationURLLoaderImplCore::NotifyResponseStarted(

ResourceResponse* response,

- scoped_ptr<StreamHandle> body) {

+ mojo::ScopedDataPipeConsumerHandle data_consumer_handle,

+ int request_id) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

TRACE_EVENT_ASYNC_END0("navigation", "Navigation redirectDelay", this);

TRACE_EVENT_ASYNC_END2("navigation", "Navigation timeToResponseStarted", this,

@@ -105,7 +106,8 @@ void NavigationURLLoaderImplCore::NotifyResponseStarted(

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(&NavigationURLLoaderImpl::NotifyResponseStarted, loader_,

- response->DeepCopy(), base::Passed(&body)));

+ response->DeepCopy(), base::Passed(&data_consumer_handle),

+ request_id));

}

void NavigationURLLoaderImplCore::NotifyRequestFailed(bool in_cache,