Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Unified Diff: Source/web/SpeechRecognitionClientProxy.cpp

Issue 169343002: [WIP]Add WebPrivateHeapPtr and use it for speech platform layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/SpeechRecognitionClientProxy.cpp
diff --git a/Source/web/SpeechRecognitionClientProxy.cpp b/Source/web/SpeechRecognitionClientProxy.cpp
index 4d5b1ebd3c87309c56a5445951f64df6cbf46dae..e83a52a4ab4199f84c2485c6e324eccf75d643e4 100644
--- a/Source/web/SpeechRecognitionClientProxy.cpp
+++ b/Source/web/SpeechRecognitionClientProxy.cpp
@@ -104,13 +104,13 @@ void SpeechRecognitionClientProxy::didReceiveResults(const WebSpeechRecognitionH
{
RefPtr<SpeechRecognition> recognition = PassRefPtr<SpeechRecognition>(handle);
haraken 2014/02/17 09:04:57 Shouldn't this be RefPtrWillBeRawPtr<SpeechRecogni
- Vector<RefPtr<SpeechRecognitionResult> > finalResultsVector(newFinalResults.size());
+ Vector<RefPtrWillBeRawPtr<SpeechRecognitionResult> > finalResultsVector(newFinalResults.size());
haraken 2014/02/17 09:04:57 This should be WillBeHeapVector<RefPtrWillBeMember
for (size_t i = 0; i < newFinalResults.size(); ++i)
- finalResultsVector[i] = static_cast<PassRefPtr<SpeechRecognitionResult> >(newFinalResults[i]);
+ finalResultsVector[i] = static_cast<PassRefPtrWillBeRawPtr<SpeechRecognitionResult> >(newFinalResults[i]);
haraken 2014/02/17 09:04:57 Can we remove this cast?
- Vector<RefPtr<SpeechRecognitionResult> > interimResultsVector(currentInterimResults.size());
+ Vector<RefPtrWillBeRawPtr<SpeechRecognitionResult> > interimResultsVector(currentInterimResults.size());
haraken 2014/02/17 09:04:57 This should be WillBeHeapVector<RefPtrWillBeMember
for (size_t i = 0; i < currentInterimResults.size(); ++i)
- interimResultsVector[i] = static_cast<PassRefPtr<SpeechRecognitionResult> >(currentInterimResults[i]);
+ interimResultsVector[i] = static_cast<PassRefPtrWillBeRawPtr<SpeechRecognitionResult> >(currentInterimResults[i]);
haraken 2014/02/17 09:04:57 Can we remove this cast?
recognition->didReceiveResults(finalResultsVector, interimResultsVector);
}

Powered by Google App Engine
This is Rietveld 408576698