Source/web/SpeechInputClientImpl.cpp - Issue 169343002: [WIP]Add WebPrivateHeapPtr and use it for speech platform layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/SpeechInputClientImpl.cpp

Issue 169343002: [WIP]Add WebPrivateHeapPtr and use it for speech platform layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/speech/SpeechRecognitionResultList.cpp ('K') | « Source/modules/speech/SpeechRecognitionResultList.cpp ('k') | Source/web/SpeechRecognitionClientProxy.cpp » ('j') | Source/web/SpeechRecognitionClientProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/SpeechInputClientImpl.cpp

diff --git a/Source/web/SpeechInputClientImpl.cpp b/Source/web/SpeechInputClientImpl.cpp

index 1026596e8f3b7fbf7f841e67dfae900e9da77edb..0eb2844d1ea4277b38ee5182cc468d6d8d640dae 100644

--- a/Source/web/SpeechInputClientImpl.cpp

+++ b/Source/web/SpeechInputClientImpl.cpp

@@ -98,7 +98,7 @@ void SpeechInputClientImpl::setRecognitionResult(int requestId, const WebSpeechI

ASSERT(m_listener);

WebCore::SpeechInputResultArray webcoreResults(results.size());

for (size_t i = 0; i < results.size(); ++i)

- webcoreResults[i] = results[i];

+ webcoreResults[i] = static_cast<WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechInputResult> >(results[i]);

haraken 2014/02/17 09:04:57 This cast looks weird. Can we remove this somehow?

m_listener->setRecognitionResult(requestId, webcoreResults);

}