Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1693213002: Revert of [NaCl SDK] Add initial support for building the SDK with gn (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, binji+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_i686_gcc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [NaCl SDK] Add initial support for building the SDK with gn (patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ ) Reason for revert: Doesn't build with clang/win and looks nontrivial to fix: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/3655/steps/compile/logs/stdio FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c ../../native_client/src/trusted/validator/driver/ncval.cc /Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj /Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) : error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings] while ((opt = getopt(argc, argv, "vd")) != -1) { ^ (and i'm guessing several more) Original issue's description: > [NaCl SDK] Add initial support for building the SDK with gn > > build_sdk.py still uses gyp. I have a followup CL to > convert that to gn. > > BUG=585999 TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585999 Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180 Cr-Commit-Position: refs/heads/master@{#375349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -74 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
D native_client_sdk/src/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/ppapi_plugin_main.c View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
Created Revert of [NaCl SDK] Add initial support for building the SDK with gn
4 years, 10 months ago (2016-02-13 05:09:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693213002/1
4 years, 10 months ago (2016-02-13 05:09:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-13 05:10:04 UTC) #4
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-13 05:24:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180 Cr-Commit-Position: refs/heads/master@{#375349}
4 years, 10 months ago (2016-02-16 22:47:31 UTC) #7
Sam Clegg
4 years, 10 months ago (2016-02-17 19:22:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1705923002/ by sbc@chromium.org.

The reason for reverting is: clang/win compile failures was fixed:
https://codereview.chromium.org/1706613002.

Powered by Google App Engine
This is Rietveld 408576698