CPUProfiler: unflake flaky CPUProfiler tests.

CPUProfiler: unflake flaky CPUProfiler tests.

Windows platform is very unstable. So we have no guarantee that the profiler
hit into the function we have to be profiled. From the other hand the profiler
records the callstack of the js function that started it.
We can use that fact and have a guarantee that the function will be in the profile.

BUG=none
TEST=SourceURLSupportForNewFunctions, LogExistingFunctionSourceURLCheck
R= svenpanne@chromium.org, yurys@chromium.org

[yurys, 2013-06-13 09:11:35]

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
File test/cctest/profiler-extension.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.cc:75: v8::DeclareExtension
kProfilerExtensionDeclaration(&kProfilerExtension);
not lgtm

This should be done only in the tests that require the extension.

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.h
File test/cctest/profiler-extension.h (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.h:30: 
#include "v8.h" ?

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.h:39: static v8::Handle<v8::Value>
StartProfiling(const v8::Arguments& args);
These two functions can be private.

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:937: v8::Local<v8::Context> context =
v8::Context::New(isolate, &config);
Can you continue using LocalContext for consistency? Note that its constructor
accepts v8::ExtensionConfiguration as first argument.

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:972: v8::Local<v8::Context> context =
v8::Context::New(isolate, &config);
Ditto.

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-profile-gene...
File test/cctest/test-profile-generator.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-profile-gene...
test/cctest/test-profile-generator.cc:34: #include "profiler-extension.h"
Should be before #include "../include/v8-profiler.h"

[Sven Panne, 2013-06-13 09:19:12]

LGTM if this consistenly un-flakes things. Can we do something similar for
CollectCpuProfile?

https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-e...
File test/cctest/profiler-extension.cc (right):

https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-e...
test/cctest/profiler-extension.cc:46: CHECK(false);
Using FATAL with a description is more helpful and clearer.

https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-e...
test/cctest/profiler-extension.cc:55: if (args.Length() > 0)
Bonus points for using a ternary ?: here...

https://chromiumcodereview.appspot.com/16932003/diff/1/test/cctest/profiler-e...
test/cctest/profiler-extension.cc:66: if (args.Length() > 0)
... and here. :-)

[yurys, 2013-06-13 09:21:07]

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
File test/cctest/profiler-extension.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.cc:75: v8::DeclareExtension
kProfilerExtensionDeclaration(&kProfilerExtension);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
> not lgtm
> 
> This should be done only in the tests that require the extension.

As discussed offline please disregard this comment.

[yurys, 2013-06-13 09:25:37]

On 2013/06/13 09:19:12, Sven Panne wrote:
> LGTM if this consistenly un-flakes things. Can we do something similar for
> CollectCpuProfile?
> 
CollectCpuProfile if the test where we want to check the sampler (see my comment
https://codereview.chromium.org/16280011/#msg3). I'm going to implement
"increasing intervals" for this test.

[loislo, 2013-06-13 10:01:41]

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
File test/cctest/profiler-extension.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.cc:46: CHECK(false);
On 2013/06/13 09:19:12, Sven Panne wrote:
> Using FATAL with a description is more helpful and clearer.

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.cc:55: if (args.Length() > 0)
On 2013/06/13 09:19:12, Sven Panne wrote:
> Bonus points for using a ternary ?: here...

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.cc:66: if (args.Length() > 0)
On 2013/06/13 09:19:12, Sven Panne wrote:
> ... and here. :-)

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extension.h
File test/cctest/profiler-extension.h (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.h:30: 
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
> #include "v8.h" ?

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/profiler-extensio...
test/cctest/profiler-extension.h:39: static v8::Handle<v8::Value>
StartProfiling(const v8::Arguments& args);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
> These two functions can be private.

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:937: v8::Local<v8::Context> context =
v8::Context::New(isolate, &config);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
> Can you continue using LocalContext for consistency? Note that its constructor
> accepts v8::ExtensionConfiguration as first argument.

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-cpu-profiler...
test/cctest/test-cpu-profiler.cc:972: v8::Local<v8::Context> context =
v8::Context::New(isolate, &config);
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
> Ditto.

Done.

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-profile-gene...
File test/cctest/test-profile-generator.cc (right):

https://codereview.chromium.org/16932003/diff/1/test/cctest/test-profile-gene...
test/cctest/test-profile-generator.cc:34: #include "profiler-extension.h"
On 2013/06/13 09:11:35, Yury Semikhatsky wrote:
> Should be before #include "../include/v8-profiler.h"

Done.

[yurys, 2013-06-13 10:06:22]

lgtm