Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 169303007: Revert r19403: "A64: Tidy up Push and Pop TODOs." (Closed)

Created:
6 years, 10 months ago by danno
Modified:
6 years, 10 months ago
Reviewers:
ulan, jbramley
CC:
v8-dev
Visibility:
Public.

Description

Revert r19403: "A64: Tidy up Push and Pop TODOs." Causes a64 debug asserts TBR=jacob.bramley@arm.com,ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -356 lines) Patch
M src/a64/code-stubs-a64.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/a64/full-codegen-a64.cc View 3 chunks +21 lines, -4 lines 0 comments Download
M src/a64/macro-assembler-a64.h View 4 chunks +4 lines, -39 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 6 chunks +16 lines, -132 lines 0 comments Download
M src/a64/macro-assembler-a64-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/a64/stub-cache-a64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-assembler-a64.cc View 4 chunks +3 lines, -166 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
danno
6 years, 10 months ago (2014-02-17 16:08:55 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r19419 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698