Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169303005: DevTools: introduce "restore defaults and reload" in settings pane. (Closed)

Created:
6 years, 10 months ago by pfeldman
Modified:
6 years, 10 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: introduce "restore defaults and reload" in settings pane. BUG=135451 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167284

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Simplified reload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M Source/devtools/front_end/SettingsScreen.js View 2 chunks +14 lines, -2 lines 0 comments Download
M Source/devtools/front_end/inspector.js View 1 2 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pfeldman
6 years, 10 months ago (2014-02-17 11:56:14 UTC) #1
pfeldman
PTAL
6 years, 10 months ago (2014-02-17 11:56:24 UTC) #2
vsevik
https://chromiumcodereview.appspot.com/169303005/diff/40001/Source/devtools/front_end/inspector.js File Source/devtools/front_end/inspector.js (left): https://chromiumcodereview.appspot.com/169303005/diff/40001/Source/devtools/front_end/inspector.js#oldcode225 Source/devtools/front_end/inspector.js:225: queryParamsObject["dockSide"] = this.dockController.dockSide(); The code around is not needed ...
6 years, 10 months ago (2014-02-17 12:38:13 UTC) #3
vsevik
lgtm
6 years, 10 months ago (2014-02-17 12:38:20 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 10 months ago (2014-02-17 13:03:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/169303005/40001
6 years, 10 months ago (2014-02-17 13:03:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 16:10:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12779
6 years, 10 months ago (2014-02-17 16:10:10 UTC) #8
pfeldman
6 years, 10 months ago (2014-02-17 16:39:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 manually as r167284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698