Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1692933002: Fix for linux make check build failure (Closed)

Created:
4 years, 10 months ago by mveljko
Modified:
4 years, 10 months ago
Reviewers:
vapier, Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com, gordana.cmiljanovic_imgtec.com, petar.jovanovic
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for linux make check build failure Linux make check is failing for mips, mips64, arm, arm64 with error: "fatal error: mach/arm/vm_types.h: No such file or directory" in case of arm, "../src/third_party/mac_headers/mach/machine/vm_types.h:37:2: error: #error architecture not supported" in case of mips/mips64 This was partially fixed in https://codereview.chromium.org/1645673002/. Here excluding src/common/mac/macho_reader_unittest for hosts other than x86/x86-64. BUG=make check failure for linux mips TEST=make check pass

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Makefile.am View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mveljko
Please take a look.
4 years, 10 months ago (2016-02-12 13:52:20 UTC) #2
vapier
lgtm
4 years, 10 months ago (2016-02-12 20:22:46 UTC) #4
vapier
4 years, 10 months ago (2016-02-12 20:23:16 UTC) #5
Message was sent while issue was closed.
Committed patchset as 1ac4dcf6f5824aba3d2c6604bb2004df93be733a

Powered by Google App Engine
This is Rietveld 408576698