only build dump_syms_mac for x86 hosts

only build dump_syms_mac for x86 hosts

The dump_syms_mac tool only works for the system it is being built for
(it doesn't support running on ELFs for a diff target), and it builds
only for x86 currently.

If you look at the mac header:
	src/third_party/mac_headers/mach/machine/vm_types.h
it will #error for non x86/arm systems, and the arm header is not in
our source tree.

Tweak the build so it's only compiled when targetting x86 systems.

BUG=chromium:579384
TEST=`make check` pass
R=ted.mielczarek@gmail.com

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/855ea963fb89b7ea89672db18304f81e65c1d6cd

[vapier, 2016-01-27 18:33:43]

vapier@chromium.org changed reviewers:
+ mark@chromium.org, ted.mielczarek@gmail.com

[vapier, 2016-01-27 18:34:50]

To clarify, all non-x86 builds are currently broken:

armv7a-unknown-linux-gnueabi-g++ -DHAVE_CONFIG_H -I. -I../../src -I./src 
-I../../src/src  -I../../src/src/third_party/mac_headers -DHAVE_MACH_O_NLIST_H
-g -O2 -std=c++11 -MT src/common/mac/src_tools_mac_dump_syms_dump_syms_ma
c-arch_utilities.o -MD -MP -MF
src/common/mac/.deps/src_tools_mac_dump_syms_dump_syms_mac-arch_utilities.Tpo -c
-o src/common/mac/src_tools_mac_dump_syms_dump_syms_mac-arch_utilities.o `test
-f 'src/common/mac/arch_utilities.c
c' || echo '../../src/'`src/common/mac/arch_utilities.cc
In file included from ../../src/src/third_party/mac_headers/mach/machine.h:64:0,
                 from ../../src/src/third_party/mac_headers/mach-o/arch.h:33,
                 from ../../src/src/common/mac/arch_utilities.h:35,
                 from ../../src/src/common/mac/arch_utilities.cc:30:
../../src/src/third_party/mac_headers/mach/machine/vm_types.h:35:31: fatal
error: mach/arm/vm_types.h: No such file or directory
 #include "mach/arm/vm_types.h"
                               ^
compilation terminated.
Makefile:6624: recipe for target
'src/common/mac/src_tools_mac_dump_syms_dump_syms_mac-arch_utilities.o' failed
make: ***
[src/common/mac/src_tools_mac_dump_syms_dump_syms_mac-arch_utilities.o] Error 1

[Mark Mentovai, 2016-01-27 18:38:09]

That’s kind of a silly restriction. Since Ted wanted this cross-OS tool, I’ll
let him comment on whether he wants to go with this or fix it for non-x86 hosts.

[vapier, 2016-01-27 18:57:07]

i agree it's a bit silly, the code doesn't work as-is, and all non-x86 targets
are broken.  we can't roll forward CrOS currently because of this.  if Ted wants
to make it work properly for all hosts, that's great, but i don't know anything
about OS X to fix myself.

[Ted Mielczarek, 2016-01-27 20:39:12]

On 2016/01/27 18:38:09, Mark Mentovai wrote:
> That’s kind of a silly restriction. Since Ted wanted this cross-OS tool, I’ll
> let him comment on whether he wants to go with this or fix it for non-x86
hosts.

I don't have any need to build this on a non-x86 host. Sorry, I didn't know
anyone was using the autoconf build system for actually building client code to
ship!

[Ted Mielczarek, 2016-01-27 20:39:22]

That is to say, LGTM.

[vapier, 2016-01-27 21:44:52]

no worries.  it's hard to fault anyone for checking in code that breaks other
configs when we don't have any bots.  we have just too many supported systems,
and haven't found cycles to put together real infra for the project :(.

[vapier, 2016-01-27 21:45:24]

Description was changed from

==========
only build dump_syms_mac for x86 hosts

The dump_syms_mac tool only works for the system it is being built for
(it doesn't support running on ELFs for a diff target), and it builds
only for x86 currently.

If you look at the mac header:
	src/third_party/mac_headers/mach/machine/vm_types.h
it will #error for non x86/arm systems, and the arm header is not in
our source tree.

Tweak the build so it's only compiled when targetting x86 systems.

BUG=chromium:579384
TEST=`make check` pass
==========

to

==========
only build dump_syms_mac for x86 hosts

The dump_syms_mac tool only works for the system it is being built for
(it doesn't support running on ELFs for a diff target), and it builds
only for x86 currently.

If you look at the mac header:
	src/third_party/mac_headers/mach/machine/vm_types.h
it will #error for non x86/arm systems, and the arm header is not in
our source tree.

Tweak the build so it's only compiled when targetting x86 systems.

BUG=chromium:579384
TEST=`make check` pass
R=ted.mielczarek@gmail.com

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/855ea963fb89b7ea89672db...
==========

[vapier, 2016-01-27 21:45:25]

Committed patchset #2 (id:20001) manually as
855ea963fb89b7ea89672db18304f81e65c1d6cd (presubmit successful).

[Ted Mielczarek, 2016-01-27 22:40:40]

On 2016/01/27 21:44:52, vapier wrote:
> no worries.  it's hard to fault anyone for checking in code that breaks other
> configs when we don't have any bots.  we have just too many supported systems,
> and haven't found cycles to put together real infra for the project :(.

I wanted to try to set something up with Travis CI but you can't push a stock
Breakpad clone to GitHub because of that 100MB file in history. :-/