sandwich: Pushes locally saved HTTP cache to the device.

sandwich: Pushes locally saved HTTP cache to the device.

BUG=582080
Committed: https://crrev.com/c240a2a6b423ed0afcc4c10ad9a03ddf544ede51
Cr-Commit-Position: refs/heads/master@{#375559}

[gabadie, 2016-02-12 14:44:59]

gabadie@chromium.org changed reviewers:
+ lizeb@chromium.org, mattcary@chromium.org, pasko@chromium.org

[gabadie, 2016-02-12 14:45:00]

lizeb@chromium.org & mattcary@chromium.org: PTAL.

[Benoit L, 2016-02-15 13:18:41]

lgtm

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:167: local_cache_path: The directory's
path containing the cache locally.
nit: document all args.

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:181: for local_directory_path, dirnames,
filenames in os.walk(
nit: blank line above would be slightly more readable.

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:263: output_directories_path: The output
directory path where to remove cleans
cannot parse sentence.

[gabadie, 2016-02-15 15:06:50]

New revision uploaded.

mattcary@chromium.org: PTAL. =)

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:167: local_cache_path: The directory's
path containing the cache locally.
On 2016/02/15 13:18:41, Benoit L wrote:
> nit: document all args.

Done.

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:181: for local_directory_path, dirnames,
filenames in os.walk(
On 2016/02/15 13:18:41, Benoit L wrote:
> nit: blank line above would be slightly more readable.

Done.

https://codereview.chromium.org/1692873003/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:263: output_directories_path: The output
directory path where to remove cleans
On 2016/02/15 13:18:41, Benoit L wrote:
> cannot parse sentence.

Done.

[mattcary, 2016-02-16 12:59:15]

lgtm

[gabadie, 2016-02-16 13:07:13]

The CQ bit was checked by gabadie@chromium.org

[gabadie, 2016-02-16 13:07:13]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/1692873003/#ps20001
(title: "Addresses lizeb's nits")

[commit-bot: I haz the power, 2016-02-16 13:07:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692873003/20001

[commit-bot: I haz the power, 2016-02-16 13:33:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 13:33:37]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[commit-bot: I haz the power, 2016-02-16 13:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[gabadie, 2016-02-16 13:35:07]

The CQ bit was checked by gabadie@chromium.org

[commit-bot: I haz the power, 2016-02-16 13:35:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692873003/20001

[commit-bot: I haz the power, 2016-02-16 13:40:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:52:27]

Description was changed from

==========
sandwich: Pushes locally saved HTTP cache to the device.

BUG=582080
==========

to

==========
sandwich: Pushes locally saved HTTP cache to the device.

BUG=582080

Committed: https://crrev.com/c240a2a6b423ed0afcc4c10ad9a03ddf544ede51
Cr-Commit-Position: refs/heads/master@{#375559}
==========

[commit-bot: I haz the power, 2016-02-16 22:52:27]

Patchset 2 (id:??) landed as
https://crrev.com/c240a2a6b423ed0afcc4c10ad9a03ddf544ede51
Cr-Commit-Position: refs/heads/master@{#375559}