sandwich: Save browser cache as zip archive preserving all timestamps

sandwich: Save browser cache as zip archive preserving all timestamps

Note that the timestamps are saved in a json in the archive to be
able to save directories's timestamps as well.

BUG=582080
Committed: https://crrev.com/2dc964d1727a9a45c94f411d959b59bcb45a33ec
Cr-Commit-Position: refs/heads/master@{#375453}

[gabadie, 2016-02-12 10:21:45]

gabadie@chromium.org changed reviewers:
+ lizeb@chromium.org, mattcary@chromium.org, pasko@chromium.org

[gabadie, 2016-02-12 10:21:46]

This CL save the browser cache in a zip file. Not that the timestamps are saved
in a json in the archive to be able to save directories timestamp as well.

lizeb@chromium.org & mattcary@chromium.org: PTAL.

[gabadie, 2016-02-12 10:43:45]

Description was changed from

==========
sandwich: Save browser cache as zip archive preserving all timestamps

BUG=582080
==========

to

==========
sandwich: Save browser cache as zip archive preserving all timestamps

Note that the timestamps are saved in a json in the archive to be
able to save directories's timestamps as well.

BUG=582080
==========

[mattcary, 2016-02-12 10:46:45]

lgtm

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:114: Oemporary directory containing all
the browser cache.
Temporary

[Benoit L, 2016-02-15 12:49:19]

lgtm

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:114: Oemporary directory containing all
the browser cache.
s/Oemporary/Temporary/

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:147: def
_ZipDirectoryContent(root_directory_path, archive_dest_path):
nit: 2 blank lines.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:148: """Zip a directory's content
recursively with all the directories's
s/'s/'/

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:179: """Unzip a directory's content
recursively with all the directories's
s/'s/'/

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:180: timestamp preserved.
timestamps.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:194: 
nit: blank line here is weird.

[gabadie, 2016-02-15 13:16:44]

Thanks you guys for you reviews! =)

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
File tools/android/loading/run_sandwich.py (right):

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:114: Oemporary directory containing all
the browser cache.
On 2016/02/12 10:46:45, mattcary wrote:
> Temporary

Done.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:147: def
_ZipDirectoryContent(root_directory_path, archive_dest_path):
On 2016/02/15 12:49:19, Benoit L wrote:
> nit: 2 blank lines.

Done.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:148: """Zip a directory's content
recursively with all the directories's
On 2016/02/15 12:49:19, Benoit L wrote:
> s/'s/'/

Done.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:179: """Unzip a directory's content
recursively with all the directories's
On 2016/02/15 12:49:19, Benoit L wrote:
> s/'s/'/

Done.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:180: timestamp preserved.
On 2016/02/15 12:49:19, Benoit L wrote:
> timestamps.

Done.

https://codereview.chromium.org/1690233002/diff/1/tools/android/loading/run_s...
tools/android/loading/run_sandwich.py:194: 
On 2016/02/15 12:49:19, Benoit L wrote:
> nit: blank line here is weird.

Done.

[gabadie, 2016-02-15 13:16:53]

The CQ bit was checked by gabadie@chromium.org

[gabadie, 2016-02-15 13:16:53]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org,
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/1690233002/#ps20001
(title: "Addresses nits")

[commit-bot: I haz the power, 2016-02-15 13:17:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1690233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1690233002/20001

[commit-bot: I haz the power, 2016-02-15 13:39:17]

Description was changed from

==========
sandwich: Save browser cache as zip archive preserving all timestamps

Note that the timestamps are saved in a json in the archive to be
able to save directories's timestamps as well.

BUG=582080
==========

to

==========
sandwich: Save browser cache as zip archive preserving all timestamps

Note that the timestamps are saved in a json in the archive to be
able to save directories's timestamps as well.

BUG=582080
==========

[commit-bot: I haz the power, 2016-02-15 13:39:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:49:55]

Description was changed from

==========
sandwich: Save browser cache as zip archive preserving all timestamps

Note that the timestamps are saved in a json in the archive to be
able to save directories's timestamps as well.

BUG=582080
==========

to

==========
sandwich: Save browser cache as zip archive preserving all timestamps

Note that the timestamps are saved in a json in the archive to be
able to save directories's timestamps as well.

BUG=582080

Committed: https://crrev.com/2dc964d1727a9a45c94f411d959b59bcb45a33ec
Cr-Commit-Position: refs/heads/master@{#375453}
==========

[commit-bot: I haz the power, 2016-02-16 22:49:56]

Patchset 2 (id:??) landed as
https://crrev.com/2dc964d1727a9a45c94f411d959b59bcb45a33ec
Cr-Commit-Position: refs/heads/master@{#375453}