Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Issue 1692743003: Fix windows build by not using strcasestr (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix windows build by not using strcasestr - Also fix no_support_timeline test. Committed: https://github.com/dart-lang/sdk/commit/87b1ead8f53ccb25b940250d69a699459ecc9203

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M runtime/vm/service.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/timeline.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
TBR
4 years, 10 months ago (2016-02-12 22:01:51 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as 87b1ead8f53ccb25b940250d69a699459ecc9203 (presubmit successful).
4 years, 10 months ago (2016-02-12 22:02:14 UTC) #6
turnidge
4 years, 10 months ago (2016-02-12 22:03:19 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698