Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: runtime/vm/timeline.cc

Issue 1692743003: Fix windows build by not using strcasestr (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.cc
diff --git a/runtime/vm/timeline.cc b/runtime/vm/timeline.cc
index 43dd5656747684370b791bced2d27e2e3159fa23..be86154914c57b0f843030abd81bd19e5abb0456 100644
--- a/runtime/vm/timeline.cc
+++ b/runtime/vm/timeline.cc
@@ -29,8 +29,8 @@ DEFINE_FLAG(charp, timeline_dir, NULL,
"into specified directory.");
DEFINE_FLAG(charp, timeline_streams, NULL,
"Comma separated list of timeline streams to record. "
- "Valid values: all, api, compiler, dart, debugger, embedder, "
- "gc, isolate, and vm.");
+ "Valid values: all, API, Compiler, Dart, Debugger, Embedder, "
+ "GC, Isolate, and VM.");
// Implementation notes:
//
@@ -115,8 +115,8 @@ static bool HasStream(MallocGrowableArray<char*>* streams, const char* stream) {
}
for (intptr_t i = 0; i < streams->length(); i++) {
const char* checked_stream = (*streams)[i];
- if ((strcasestr(checked_stream, "all") != NULL) ||
- (strcasestr(checked_stream, stream) != NULL)) {
+ if ((strstr(checked_stream, "all") != NULL) ||
+ (strstr(checked_stream, stream) != NULL)) {
return true;
}
}
@@ -181,6 +181,9 @@ TimelineEventRecorder* Timeline::recorder() {
void Timeline::SetupIsolateStreams(Isolate* isolate) {
+ if (!FLAG_support_timeline) {
+ return;
+ }
#define ISOLATE_TIMELINE_STREAM_INIT(name, enabled_by_default) \
isolate->Get##name##Stream()->Init( \
#name, \
« no previous file with comments | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698