Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: sandbox/win/src/Wow64.cc

Issue 169193002: Convert scoped_ptr_malloc -> scoped_ptr, part 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket_stream/socket_stream.h ('k') | sandbox/win/src/acl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sandbox/win/src/wow64.h" 5 #include "sandbox/win/src/wow64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 size_t name_pos = path.find_last_of(L"\\"); 146 size_t name_pos = path.find_last_of(L"\\");
147 if (base::string16::npos == name_pos) 147 if (base::string16::npos == name_pos)
148 return false; 148 return false;
149 path.resize(name_pos + 1); 149 path.resize(name_pos + 1);
150 150
151 std::basic_stringstream<base::char16> command; 151 std::basic_stringstream<base::char16> command;
152 command << std::hex << std::showbase << L"\"" << path << 152 command << std::hex << std::showbase << L"\"" << path <<
153 L"wow_helper.exe\" " << child_->ProcessId() << " " << 153 L"wow_helper.exe\" " << child_->ProcessId() << " " <<
154 bit_cast<ULONG>(buffer); 154 bit_cast<ULONG>(buffer);
155 155
156 scoped_ptr_malloc<wchar_t> writable_command(_wcsdup(command.str().c_str())); 156 scoped_ptr<wchar_t, base::FreeDeleter>
157 writable_command(_wcsdup(command.str().c_str()));
157 158
158 STARTUPINFO startup_info = {0}; 159 STARTUPINFO startup_info = {0};
159 startup_info.cb = sizeof(startup_info); 160 startup_info.cb = sizeof(startup_info);
160 PROCESS_INFORMATION temp_process_info = {}; 161 PROCESS_INFORMATION temp_process_info = {};
161 if (!::CreateProcess(NULL, writable_command.get(), NULL, NULL, FALSE, 0, NULL, 162 if (!::CreateProcess(NULL, writable_command.get(), NULL, NULL, FALSE, 0, NULL,
162 NULL, &startup_info, &temp_process_info)) 163 NULL, &startup_info, &temp_process_info))
163 return false; 164 return false;
164 base::win::ScopedProcessInformation process_info(temp_process_info); 165 base::win::ScopedProcessInformation process_info(temp_process_info);
165 166
166 DWORD reason = ::WaitForSingleObject(process_info.process_handle(), INFINITE); 167 DWORD reason = ::WaitForSingleObject(process_info.process_handle(), INFINITE);
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 SIZE_T read; 212 SIZE_T read;
212 if (!::ReadProcessMemory(child_->Process(), ntdll_, &buffer, kBufferSize, 213 if (!::ReadProcessMemory(child_->Process(), ntdll_, &buffer, kBufferSize,
213 &read)) 214 &read))
214 return false; 215 return false;
215 if (kBufferSize != read) 216 if (kBufferSize != read)
216 return false; 217 return false;
217 return true; 218 return true;
218 } 219 }
219 220
220 } // namespace sandbox 221 } // namespace sandbox
OLDNEW
« no previous file with comments | « net/socket_stream/socket_stream.h ('k') | sandbox/win/src/acl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698