Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl

Issue 1691883003: Deprecate SVGZoomEvent and SVGZoomEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Time to update histograms.xml Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
index f893780fa8857df0941555c4fc8404c87faa838b..64f83868d1a10bd31cbfd4c7b0fc8b31b366020f 100644
--- a/third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
@@ -16,14 +16,17 @@ namespace blink {
PassRefPtrWillBeRawPtr<{{namespace}}> {{namespace}}{{suffix}}Factory::create(ExecutionContext* executionContext, const String& type)
{
{% for event in events %}
- {% if event|script_name|case_insensitive_matching %}
+ {% if event|script_name|create_event_whitelist %}
if (equalIgnoringCase(type, "{{event|script_name}}"){% if event.RuntimeEnabled %} && RuntimeEnabledFeatures::{{event.RuntimeEnabled|lower_first}}(){% endif %}) {
{% else %}
if (type == "{{event|script_name}}"{% if event.RuntimeEnabled %} && RuntimeEnabledFeatures::{{event.RuntimeEnabled|lower_first}}(){% endif %}) {
{% endif %}
- {% if not event|script_name|candidate_whitelist %}
+ {% if not event|script_name|create_event_whitelist and not event|script_name|create_event_deprecate_list %}
UseCounter::count(executionContext, UseCounter::{{event|script_name|measure_name}});
{% endif %}
+ {% if event|script_name|create_event_deprecate_list %}
philipj_slow 2016/02/13 14:48:00 Could this be written in an {% else %} branch with
davve 2016/02/16 08:16:35 Good idea, I like that.
+ UseCounter::countDeprecation(executionContext, UseCounter::{{event|script_name|deprecate_name}});
+ {% endif %}
return {{event|cpp_name}}::create();
}
{% endfor %}

Powered by Google App Engine
This is Rietveld 408576698