Chromium Code Reviews| Index: third_party/WebKit/Source/build/scripts/make_event_factory.py |
| diff --git a/third_party/WebKit/Source/build/scripts/make_event_factory.py b/third_party/WebKit/Source/build/scripts/make_event_factory.py |
| index 7a9d9c28e02cf12d0c26a3ef4abef78dc00650e2..6e2f206d8f28692761ebdf217816f89493cd7dcb 100755 |
| --- a/third_party/WebKit/Source/build/scripts/make_event_factory.py |
| +++ b/third_party/WebKit/Source/build/scripts/make_event_factory.py |
| @@ -47,12 +47,16 @@ HEADER_TEMPLATE = """%(license)s |
| """ |
| -# The list is a close match to: |
| +# All events on the following whitelist are matched case-insensitively |
| +# in createEvent. |
| # |
| -# https://dom.spec.whatwg.org/#dom-document-createevent |
| +# All events not on the list are being measured (except for already |
| +# deprecated ones). The plan is to limit createEvent to just a few |
| +# selected events necessary for legacy content in accordance with the |
| +# specification: |
| # |
| -# with the exepction for |keyevents| not present in Blink. |
| -def case_insensitive_matching(name): |
| +# See https://dom.spec.whatwg.org/#dom-document-createevent |
|
philipj_slow
2016/02/13 14:48:00
The ":" and the "See" kind of serve the same purpo
davve
2016/02/16 08:16:35
Done.
|
| +def create_event_whitelist(name): |
| return (name == ('HTMLEvents') |
| or name == 'Event' |
| or name == 'Events' |
| @@ -64,21 +68,21 @@ def case_insensitive_matching(name): |
| or name == 'TouchEvent') |
| -# All events not on the following whitelist are being measured in |
| -# createEvent. The plan is to limit createEvent to just a few selected |
| -# events necessary for legacy content in accordance with the |
| -# specification: |
| -# |
| -# https://dom.spec.whatwg.org/#dom-document-createevent |
| -def candidate_whitelist(name): |
| - return (case_insensitive_matching(name) |
| - or name == 'SVGZoomEvent' # Will be deprecated instead. |
| - or name == 'SVGZoomEvents') # Will be deprecated instead. |
| +def create_event_deprecate_list(name): |
|
philipj_slow
2016/02/13 14:48:00
Yeah, with some luck we can make this a very big l
|
| + return (name == 'SVGZoomEvent' |
| + or name == 'SVGZoomEvents') |
| def measure_name(name): |
| return 'DocumentCreateEvent' + name |
| + |
| +def deprecate_name(name): |
| + if (name.startswith('SVGZoomEvent')): |
| + return 'DeprecateSVGZoomEvent' |
| + return None |
| + |
| + |
| class EventFactoryWriter(in_generator.Writer): |
| defaults = { |
| 'ImplementedAs': None, |
| @@ -92,10 +96,11 @@ class EventFactoryWriter(in_generator.Writer): |
| filters = { |
| 'cpp_name': name_utilities.cpp_name, |
| 'lower_first': name_utilities.lower_first, |
| - 'case_insensitive_matching': case_insensitive_matching, |
| 'script_name': name_utilities.script_name, |
| - 'candidate_whitelist': candidate_whitelist, |
| + 'create_event_whitelist': create_event_whitelist, |
| + 'create_event_deprecate_list': create_event_deprecate_list, |
| 'measure_name': measure_name, |
| + 'deprecate_name': deprecate_name, |
| } |
| def __init__(self, in_file_path): |