Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 169173003: content: Do not call empty methods of WebScriptController. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jamesr, abarth-chromium, darin (slow to review)
Visibility:
Public.

Description

content: Do not call empty methods of WebScriptController. enableV8SingleThreadMode() and flushConsoleMessages() do nothing in their Blink implementation, so we don't need to call them as they won't do anything at all. BUG=None TEST=content_shell, content_unittests R=abarth@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/public/test/render_view_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 10 months ago (2014-02-17 03:12:08 UTC) #1
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-17 04:36:23 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-17 14:23:48 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-18 02:19:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/169173003/1
6 years, 10 months ago (2014-02-18 02:19:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 02:19:08 UTC) #6
commit-bot: I haz the power
Failed to apply patch for content/test/test_webkit_platform_support.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-18 02:19:08 UTC) #7
tfarina
6 years, 10 months ago (2014-02-18 02:40:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r251716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698