Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: content/public/test/render_view_test.cc

Issue 169173003: content: Do not call empty methods of WebScriptController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/test/render_view_test.h" 5 #include "content/public/test/render_view_test.h"
6 6
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "content/common/dom_storage/dom_storage_types.h" 8 #include "content/common/dom_storage/dom_storage_types.h"
9 #include "content/common/frame_messages.h" 9 #include "content/common/frame_messages.h"
10 #include "content/common/input_messages.h" 10 #include "content/common/input_messages.h"
11 #include "content/common/view_messages.h" 11 #include "content/common/view_messages.h"
12 #include "content/public/browser/native_web_keyboard_event.h" 12 #include "content/public/browser/native_web_keyboard_event.h"
13 #include "content/public/common/renderer_preferences.h" 13 #include "content/public/common/renderer_preferences.h"
14 #include "content/public/renderer/history_item_serialization.h" 14 #include "content/public/renderer/history_item_serialization.h"
15 #include "content/renderer/render_thread_impl.h" 15 #include "content/renderer/render_thread_impl.h"
16 #include "content/renderer/render_view_impl.h" 16 #include "content/renderer/render_view_impl.h"
17 #include "content/renderer/renderer_main_platform_delegate.h" 17 #include "content/renderer/renderer_main_platform_delegate.h"
18 #include "content/renderer/renderer_webkitplatformsupport_impl.h" 18 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
19 #include "content/test/mock_render_process.h" 19 #include "content/test/mock_render_process.h"
20 #include "third_party/WebKit/public/platform/WebScreenInfo.h" 20 #include "third_party/WebKit/public/platform/WebScreenInfo.h"
21 #include "third_party/WebKit/public/platform/WebURLRequest.h" 21 #include "third_party/WebKit/public/platform/WebURLRequest.h"
22 #include "third_party/WebKit/public/web/WebFrame.h" 22 #include "third_party/WebKit/public/web/WebFrame.h"
23 #include "third_party/WebKit/public/web/WebHistoryItem.h" 23 #include "third_party/WebKit/public/web/WebHistoryItem.h"
24 #include "third_party/WebKit/public/web/WebInputEvent.h" 24 #include "third_party/WebKit/public/web/WebInputEvent.h"
25 #include "third_party/WebKit/public/web/WebKit.h" 25 #include "third_party/WebKit/public/web/WebKit.h"
26 #include "third_party/WebKit/public/web/WebScriptController.h"
27 #include "third_party/WebKit/public/web/WebScriptSource.h" 26 #include "third_party/WebKit/public/web/WebScriptSource.h"
28 #include "third_party/WebKit/public/web/WebView.h" 27 #include "third_party/WebKit/public/web/WebView.h"
29 #include "ui/base/resource/resource_bundle.h" 28 #include "ui/base/resource/resource_bundle.h"
30 #include "v8/include/v8.h" 29 #include "v8/include/v8.h"
31 30
32 #if defined(OS_MACOSX) 31 #if defined(OS_MACOSX)
33 #include "base/mac/scoped_nsautorelease_pool.h" 32 #include "base/mac/scoped_nsautorelease_pool.h"
34 #endif 33 #endif
35 34
36 using blink::WebFrame; 35 using blink::WebFrame;
37 using blink::WebInputEvent; 36 using blink::WebInputEvent;
38 using blink::WebMouseEvent; 37 using blink::WebMouseEvent;
39 using blink::WebScriptController;
40 using blink::WebScriptSource; 38 using blink::WebScriptSource;
41 using blink::WebString; 39 using blink::WebString;
42 using blink::WebURLRequest; 40 using blink::WebURLRequest;
43 41
44 namespace { 42 namespace {
45 const int32 kOpenerId = -2; 43 const int32 kOpenerId = -2;
46 const int32 kRouteId = 5; 44 const int32 kRouteId = 5;
47 const int32 kMainFrameRouteId = 6; 45 const int32 kMainFrameRouteId = 6;
48 const int32 kNewWindowRouteId = 7; 46 const int32 kNewWindowRouteId = 7;
49 const int32 kNewFrameRouteId = 10; 47 const int32 kNewFrameRouteId = 10;
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 FrameMsg_Navigate navigate_message(impl->main_render_frame()->GetRoutingID(), 392 FrameMsg_Navigate navigate_message(impl->main_render_frame()->GetRoutingID(),
395 navigate_params); 393 navigate_params);
396 impl->main_render_frame()->OnMessageReceived(navigate_message); 394 impl->main_render_frame()->OnMessageReceived(navigate_message);
397 395
398 // The load actually happens asynchronously, so we pump messages to process 396 // The load actually happens asynchronously, so we pump messages to process
399 // the pending continuation. 397 // the pending continuation.
400 ProcessPendingMessages(); 398 ProcessPendingMessages();
401 } 399 }
402 400
403 } // namespace content 401 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698