Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 1691693002: Serialize local functions and variables. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Remove unused class. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/idl.dart
diff --git a/pkg/analyzer/lib/src/summary/idl.dart b/pkg/analyzer/lib/src/summary/idl.dart
index b671751c71b08b0c3e0ab61d4fe2a13f5d295791..903732e25ec2afcf6b2175b93c5dfb4cd76921ea 100644
--- a/pkg/analyzer/lib/src/summary/idl.dart
+++ b/pkg/analyzer/lib/src/summary/idl.dart
@@ -991,6 +991,11 @@ abstract class UnlinkedExecutable extends base.SummaryClass {
UnlinkedDocumentationComment get documentationComment;
/**
+ * The list of local functions.
+ */
+ List<UnlinkedExecutable> get executables;
Paul Berry 2016/02/11 15:29:19 I'd prefer if we called this "localFunctions" for
scheglov 2016/02/11 15:50:08 Done! Actually I named them as localFunctions and
+
+ /**
* If this executable's return type is inferable, nonzero slot id
* identifying which entry in [LinkedUnit.types] contains the inferred
* return type. If there is no matching entry in [LinkedUnit.types], then
@@ -1086,6 +1091,21 @@ abstract class UnlinkedExecutable extends base.SummaryClass {
* method syntax is disabled.
*/
List<UnlinkedTypeParam> get typeParameters;
+
+ /**
+ * The list of local variable.
Paul Berry 2016/02/11 15:29:19 s/variable/variables/
scheglov 2016/02/11 15:50:08 Done.
+ */
+ List<UnlinkedVariable> get variables;
Paul Berry 2016/02/11 15:29:19 Similarly, this should be called "localVariables".
scheglov 2016/02/11 15:50:08 Done.
+
+ /**
+ * If a local function, the length of the visible range; absent otherwise.
Paul Berry 2016/02/11 15:29:19 s/absent/zero/ here and in 3 other places below.
scheglov 2016/02/11 15:50:08 Done.
+ */
+ int get visibleLength;
+
+ /**
+ * If a local function, the beginning of the visible range; absent otherwise.
+ */
+ int get visibleOffset;
}
/**
@@ -1668,4 +1688,14 @@ abstract class UnlinkedVariable extends base.SummaryClass {
* Declared type of the variable. Absent if the type is implicit.
*/
EntityRef get type;
+
+ /**
+ * If a local variable, the length of the visible range; absent otherwise.
+ */
+ int get visibleLength;
+
+ /**
+ * If a local variable, the beginning of the visible range; absent otherwise.
+ */
+ int get visibleOffset;
}

Powered by Google App Engine
This is Rietveld 408576698