Serialize local functions and variables.

pkg/analyzer/lib/src/summary/idl.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file is an "idl" style description of the summary format.  It
  * contains abstract classes which declare the interface for reading data from
  * summaries.  It is parsed and transformed into code that implements the
  * summary format.
  *
@@ skipping 973 matching lines @@
   List<UnlinkedConstructorInitializer> get constantInitializers;
 
   /**
    * Documentation comment for the executable, or `null` if there is no
    * documentation comment.
    */
   @informative
   UnlinkedDocumentationComment get documentationComment;
 
   /**
+   * The list of local functions.
+   */
+  List<UnlinkedExecutable> get executables;

[Paul Berry, 2016/02/11 15:29:19]

I'd prefer if we called this "localFunctions" for clarity.

[scheglov, 2016/02/11 15:50:08]

Done!
Actually I named them as localFunctions and localVariables initially, but then
thought that maybe they should be named as other similar fields :-)

+
+  /**
    * If this executable's return type is inferable, nonzero slot id
    * identifying which entry in [LinkedUnit.types] contains the inferred
    * return type.  If there is no matching entry in [LinkedUnit.types], then
    * no return type was inferred for this variable, so its static type is
    * `dynamic`.
    */
   int get inferredReturnTypeSlot;
 
   /**
    * Indicates whether the executable is declared using the `abstract` keyword.
@@ skipping 75 matching lines @@
    * Declared return type of the executable.  Absent if the executable is a
    * constructor or the return type is implicit.
    */
   EntityRef get returnType;
 
   /**
    * Type parameters of the executable, if any.  Empty if support for generic
    * method syntax is disabled.
    */
   List<UnlinkedTypeParam> get typeParameters;
+
+  /**
+   * The list of local variable.

[Paul Berry, 2016/02/11 15:29:19]

s/variable/variables/

[scheglov, 2016/02/11 15:50:08]

Done.

+   */
+  List<UnlinkedVariable> get variables;

[Paul Berry, 2016/02/11 15:29:19]

Similarly, this should be called "localVariables".

[scheglov, 2016/02/11 15:50:08]

Done.

+
+  /**
+   * If a local function, the length of the visible range; absent otherwise.

[Paul Berry, 2016/02/11 15:29:19]

s/absent/zero/ here and in 3 other places below.

(The fact that ints with a value of zero don't take up any space in the
serialized output is an implementation detail of Flatbuffers which shouldn't be
leaked to this level of abstraction)

[scheglov, 2016/02/11 15:50:08]

Done.

+   */
+  int get visibleLength;
+
+  /**
+   * If a local function, the beginning of the visible range; absent otherwise.
+   */
+  int get visibleOffset;
 }
 
 /**
  * Enum used to indicate the kind of an executable.
  */
 enum UnlinkedExecutableKind {
   /**
    * Executable is a function or method.
    */
   functionOrMethod,
@@ skipping 562 matching lines @@
    * propagated type is the same as its declared type.
    *
    * Non-propagable variables have a [propagatedTypeSlot] of zero.
    */
   int get propagatedTypeSlot;
 
   /**
    * Declared type of the variable.  Absent if the type is implicit.
    */
   EntityRef get type;
+
+  /**
+   * If a local variable, the length of the visible range; absent otherwise.
+   */
+  int get visibleLength;
+
+  /**
+   * If a local variable, the beginning of the visible range; absent otherwise.
+   */
+  int get visibleOffset;
 }