Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1691653002: Remove kIsPossibleArrowFormals option from ParseAssignmentExpression (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@smaller-cleanup
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove kIsPossibleArrowFormals option from ParseAssignmentExpression The path used by that option only comes into play when default parameters are allowed but destructuring assignment is disallowed. Removing it allows the removal of one implementation of ParseExpression, and makes it clearer which code will be dead once all the destructuring flags are removed. Also made the |flags| param strongly typed instead of an int. Committed: https://crrev.com/b8a4aeaee04120fa8d560b1e30083277cc6a34eb Cr-Commit-Position: refs/heads/master@{#33918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M src/parsing/parser-base.h View 9 chunks +17 lines, -24 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
adamk
This depends on https://codereview.chromium.org/1688833004 landing first
4 years, 10 months ago (2016-02-11 01:19:54 UTC) #2
rossberg
lgtm
4 years, 10 months ago (2016-02-11 11:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691653002/1
4 years, 10 months ago (2016-02-11 19:09:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 19:10:20 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 19:11:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8a4aeaee04120fa8d560b1e30083277cc6a34eb
Cr-Commit-Position: refs/heads/master@{#33918}

Powered by Google App Engine
This is Rietveld 408576698