Cleanup destructuring-related error reporting in ParserBase

Cleanup destructuring-related error reporting in ParserBase

Several minor cleanups to error handling in expression parsing:
  - Remove duplication of binding and assignment error reporting.
  - RecordBindingPatternError calls are changed to shorter BindingPatternUnexpectedToken
    calls where possible.
  - No-op error recording calls are removed.

Committed: https://crrev.com/0b271defa5c536f812df68e54f655a38b60ee82a
Cr-Commit-Position: refs/heads/master@{#33915}

[adamk, 2016-02-11 00:31:11]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[adamk, 2016-02-11 00:31:12]

This changes a few error messages (around using non-'=' operators or arrow
functions on the LHS of destructuring assignments), but in ways that don't seem
bad to me; the lack of duplication in the parser seems worth it.

[caitp (gmail), 2016-02-11 01:39:16]

On 2016/02/11 00:31:12, adamk wrote:
> This changes a few error messages (around using non-'=' operators or arrow
> functions on the LHS of destructuring assignments), but in ways that don't
seem
> bad to me; the lack of duplication in the parser seems worth it.

looks pretty good --- the caveat is that RecordBindingPatternError technically
does less work than RecordPatternError, but it probably doesn't matter that much

[rossberg, 2016-02-11 11:53:24]

lgtm

[adamk, 2016-02-11 18:53:54]

On 2016/02/11 01:39:16, caitp wrote:
> On 2016/02/11 00:31:12, adamk wrote:
> > This changes a few error messages (around using non-'=' operators or arrow
> > functions on the LHS of destructuring assignments), but in ways that don't
> seem
> > bad to me; the lack of duplication in the parser seems worth it.
> 
> looks pretty good --- the caveat is that RecordBindingPatternError technically
> does less work than RecordPatternError, but it probably doesn't matter that
much

Yeah, I'm not too worried about that extra work; if it's a problem, then we
should change all the _other_ callers of BindingPatternUnexpectedToken() and
friends.

[adamk, 2016-02-11 18:53:58]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-02-11 18:54:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1688833004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1688833004/1

[commit-bot: I haz the power, 2016-02-11 18:57:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-11 18:57:19]

Description was changed from

==========
Cleanup destructuring-related error reporting in ParserBase

Several minor cleanups to error handling in expression parsing:
  - Remove duplication of binding and assignment error reporting.
  - RecordBindingPatternError calls are changed to shorter
BindingPatternUnexpectedToken
    calls where possible.
  - No-op error recording calls are removed.
==========

to

==========
Cleanup destructuring-related error reporting in ParserBase

Several minor cleanups to error handling in expression parsing:
  - Remove duplication of binding and assignment error reporting.
  - RecordBindingPatternError calls are changed to shorter
BindingPatternUnexpectedToken
    calls where possible.
  - No-op error recording calls are removed.

Committed: https://crrev.com/0b271defa5c536f812df68e54f655a38b60ee82a
Cr-Commit-Position: refs/heads/master@{#33915}
==========

[commit-bot: I haz the power, 2016-02-11 18:57:20]

Patchset 1 (id:??) landed as
https://crrev.com/0b271defa5c536f812df68e54f655a38b60ee82a
Cr-Commit-Position: refs/heads/master@{#33915}