Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4573)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 9d25844dfe378c8096307011d3382238cce732fb..8981d53105bb0639c939f49b2081e4610b0535de 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -168,8 +168,8 @@ const char kUserCancelledError[] = "User cancelled install";
// Helper to create a dictionary with login properties set from the appropriate
// values in the passed-in |profile|.
-DictionaryValue* CreateLoginResult(Profile* profile) {
- DictionaryValue* dictionary = new DictionaryValue();
+base::DictionaryValue* CreateLoginResult(Profile* profile) {
+ base::DictionaryValue* dictionary = new base::DictionaryValue();
std::string username = profile->GetPrefs()->GetString(
prefs::kGoogleServicesUsername);
dictionary->SetString(kLoginKey, username);
@@ -222,7 +222,7 @@ InstallBundleFunction::InstallBundleFunction() {}
InstallBundleFunction::~InstallBundleFunction() {}
bool InstallBundleFunction::RunImpl() {
- ListValue* extensions = NULL;
+ base::ListValue* extensions = NULL;
EXTENSION_FUNCTION_VALIDATE(args_->GetList(0, &extensions));
BundleInstaller::ItemList items;
@@ -237,10 +237,10 @@ bool InstallBundleFunction::RunImpl() {
return true;
}
-bool InstallBundleFunction::ReadBundleInfo(ListValue* extensions,
+bool InstallBundleFunction::ReadBundleInfo(base::ListValue* extensions,
BundleInstaller::ItemList* items) {
for (size_t i = 0; i < extensions->GetSize(); ++i) {
- DictionaryValue* details = NULL;
+ base::DictionaryValue* details = NULL;
EXTENSION_FUNCTION_VALIDATE(extensions->GetDictionary(i, &details));
BundleInstaller::Item item;
@@ -286,7 +286,7 @@ BeginInstallWithManifestFunction::BeginInstallWithManifestFunction()
BeginInstallWithManifestFunction::~BeginInstallWithManifestFunction() {}
bool BeginInstallWithManifestFunction::RunImpl() {
- DictionaryValue* details = NULL;
+ base::DictionaryValue* details = NULL;
EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &details));
CHECK(details);
@@ -401,7 +401,7 @@ void BeginInstallWithManifestFunction::SetResultCode(ResultCode code) {
void BeginInstallWithManifestFunction::OnWebstoreParseSuccess(
const std::string& id,
const SkBitmap& icon,
- DictionaryValue* parsed_manifest) {
+ base::DictionaryValue* parsed_manifest) {
CHECK_EQ(id_, id);
CHECK(parsed_manifest);
icon_ = icon;

Powered by Google App Engine
This is Rietveld 408576698