Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: chrome/browser/extensions/api/runtime/runtime_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/runtime/runtime_api.cc
diff --git a/chrome/browser/extensions/api/runtime/runtime_api.cc b/chrome/browser/extensions/api/runtime/runtime_api.cc
index d00ab43742ef23669051039745d9107635140033..bdfff1f6281f480aa7f9b75470dc720e7b11be9f 100644
--- a/chrome/browser/extensions/api/runtime/runtime_api.cc
+++ b/chrome/browser/extensions/api/runtime/runtime_api.cc
@@ -100,7 +100,7 @@ static void DispatchOnStartupEventImpl(
return;
}
- scoped_ptr<base::ListValue> event_args(new ListValue());
+ scoped_ptr<base::ListValue> event_args(new base::ListValue());
scoped_ptr<Event> event(new Event(kOnStartupEvent, event_args.Pass()));
system->event_router()->DispatchEventToExtension(extension_id, event.Pass());
}
@@ -143,7 +143,7 @@ void RuntimeEventRouter::DispatchOnInstalledEvent(
// chance to register for events. So we register on its behalf. If the
// extension does not actually have a listener, the event will just be
// ignored.
- scoped_ptr<base::ListValue> event_args(new ListValue());
+ scoped_ptr<base::ListValue> event_args(new base::ListValue());
base::DictionaryValue* info = new base::DictionaryValue();
event_args->Append(info);
if (old_version.IsValid()) {
@@ -166,12 +166,12 @@ void RuntimeEventRouter::DispatchOnInstalledEvent(
void RuntimeEventRouter::DispatchOnUpdateAvailableEvent(
Profile* profile,
const std::string& extension_id,
- const DictionaryValue* manifest) {
+ const base::DictionaryValue* manifest) {
ExtensionSystem* system = ExtensionSystem::Get(profile);
if (!system)
return;
- scoped_ptr<ListValue> args(new ListValue);
+ scoped_ptr<base::ListValue> args(new base::ListValue);
args->Append(manifest->DeepCopy());
DCHECK(system->event_router());
scoped_ptr<Event> event(new Event(kOnUpdateAvailableEvent, args.Pass()));
@@ -185,7 +185,7 @@ void RuntimeEventRouter::DispatchOnBrowserUpdateAvailableEvent(
if (!system)
return;
- scoped_ptr<ListValue> args(new ListValue);
+ scoped_ptr<base::ListValue> args(new base::ListValue);
DCHECK(system->event_router());
scoped_ptr<Event> event(new Event(kOnBrowserUpdateAvailableEvent,
args.Pass()));
@@ -409,7 +409,7 @@ bool RuntimeGetPackageDirectoryEntryFunction::RunImpl() {
if (!policy->CanReadFile(renderer_id, path))
policy->GrantReadFile(renderer_id, path);
- DictionaryValue* dict = new DictionaryValue();
+ base::DictionaryValue* dict = new base::DictionaryValue();
SetResult(dict);
dict->SetString("fileSystemId", filesystem_id);
dict->SetString("baseName", relative_path);

Powered by Google App Engine
This is Rietveld 408576698