Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_api.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc
index 72fc053ad9f0b8c4c9954b67e792378547028137..c9d62938bf48d12d31af23636583de32bdb1edf8 100644
--- a/chrome/browser/extensions/api/cookies/cookies_api.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_api.cc
@@ -82,8 +82,8 @@ void CookiesEventRouter::Observe(
void CookiesEventRouter::CookieChanged(
Profile* profile,
ChromeCookieDetails* details) {
- scoped_ptr<ListValue> args(new ListValue());
- DictionaryValue* dict = new DictionaryValue();
+ scoped_ptr<base::ListValue> args(new base::ListValue());
+ base::DictionaryValue* dict = new base::DictionaryValue();
dict->SetBoolean(keys::kRemovedKey, details->removed);
scoped_ptr<Cookie> cookie(
@@ -129,7 +129,7 @@ void CookiesEventRouter::CookieChanged(
void CookiesEventRouter::DispatchEvent(
Profile* profile,
const std::string& event_name,
- scoped_ptr<ListValue> event_args,
+ scoped_ptr<base::ListValue> event_args,
GURL& cookie_domain) {
EventRouter* router = profile ?
extensions::ExtensionSystem::Get(profile)->event_router() : NULL;
@@ -511,13 +511,13 @@ void CookiesRemoveFunction::RespondOnUIThread() {
bool CookiesGetAllCookieStoresFunction::RunImpl() {
Profile* original_profile = profile();
DCHECK(original_profile);
- scoped_ptr<ListValue> original_tab_ids(new ListValue());
+ scoped_ptr<base::ListValue> original_tab_ids(new base::ListValue());
Profile* incognito_profile = NULL;
- scoped_ptr<ListValue> incognito_tab_ids;
+ scoped_ptr<base::ListValue> incognito_tab_ids;
if (include_incognito() && profile()->HasOffTheRecordProfile()) {
incognito_profile = profile()->GetOffTheRecordProfile();
if (incognito_profile)
- incognito_tab_ids.reset(new ListValue());
+ incognito_tab_ids.reset(new base::ListValue());
}
DCHECK(original_profile != incognito_profile);

Powered by Google App Engine
This is Rietveld 408576698