Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1691383002: Make SkRWBuffer destruct safely (Closed)

Created:
4 years, 10 months ago by scroggo
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkRWBuffer destruct safely Check for NULL before calling unref. Add a test. BUG=483369 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691383002 Committed: https://skia.googlesource.com/skia/+/9dec5d2acdd12202a1f0ed571cb5ecee574a2550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/core/SkRWBuffer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/DataRefTest.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
4 years, 10 months ago (2016-02-12 15:45:31 UTC) #3
reed1
lgtm
4 years, 10 months ago (2016-02-15 21:13:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691383002/1
4 years, 10 months ago (2016-02-16 14:38:11 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 14:59:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9dec5d2acdd12202a1f0ed571cb5ecee574a2550

Powered by Google App Engine
This is Rietveld 408576698