src/core/SkRWBuffer.cpp - Issue 1691383002: Make SkRWBuffer destruct safely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkRWBuffer.cpp

Issue 1691383002: Make SkRWBuffer destruct safely (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkRWBuffer.cpp

diff --git a/src/core/SkRWBuffer.cpp b/src/core/SkRWBuffer.cpp

index 0784378d99a77d9c084f02d4f6b7d57476b7ae60..c0a93bdf53c037ce768a0699983f1d7cf1ce30d5 100644

--- a/src/core/SkRWBuffer.cpp

+++ b/src/core/SkRWBuffer.cpp

@@ -168,7 +168,9 @@ SkRWBuffer::SkRWBuffer(size_t initialCapacity) : fHead(nullptr), fTail(nullptr),

SkRWBuffer::~SkRWBuffer() {

this->validate();

- fHead->unref();

+ if (fHead) {

+ fHead->unref();

+ }

}

void SkRWBuffer::append(const void* src, size_t length) {

« no previous file with comments | « no previous file | tests/DataRefTest.cpp » ('j') | no next file with comments »