src/IceTargetLoweringX8664.cpp - Issue 1691193002: Subzero: Prototype to make use of RegNumT::No Register more concise

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8664.cpp

Issue 1691193002: Subzero: Prototype to make use of RegNumT::No Register more concise (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: changes suggested by stichnot Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8664.cpp

diff --git a/src/IceTargetLoweringX8664.cpp b/src/IceTargetLoweringX8664.cpp

index ecf86b003f5f82e90b71db8d383130e9468bd84b..86956cd3a51246791676e2fcf0045cf3613e5671 100644

--- a/src/IceTargetLoweringX8664.cpp

+++ b/src/IceTargetLoweringX8664.cpp

@@ -419,8 +419,7 @@ Traits::X86OperandMem *TargetX8664::_sandbox_mem_reference(X86OperandMem *Mem) {

}

- auto RegNum = RegNumT::NoRegister;

- auto RegNum32 = RegNumT::NoRegister;

+ RegNumT RegNum, RegNum32;

if (T != nullptr) {

if (T->hasReg()) {

RegNum = Traits::getGprForType(IceType_i64, T->getRegNum());

« no previous file with comments | « src/IceTargetLoweringX8632Traits.h ('k') | src/IceTargetLoweringX8664Traits.h » ('j') | no next file with comments »