Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1691163002: Fix background compilation crashes due to allocation of types in new space. Remove default argument… (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix background compilation crashes due to allocation of types in new space. Remove default arguments of InstantiateFrom and others where space argument is being passed, in order to preemptively fix crashes and prevent future problems (always be explicit where the type is allocated, make sure the 'space' argument is propagated). BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/72528aba8521151436e6e73aa2e25fdec3a3632b

Patch Set 1 #

Patch Set 2 : flag #

Patch Set 3 : e #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -58 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/object.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 15 chunks +37 lines, -37 lines 0 comments Download
M runtime/vm/object.cc View 1 2 8 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 10 months ago (2016-02-12 00:00:11 UTC) #2
regis
LGTM
4 years, 10 months ago (2016-02-12 00:32:27 UTC) #3
srdjan
4 years, 10 months ago (2016-02-12 17:05:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
72528aba8521151436e6e73aa2e25fdec3a3632b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698