runtime/lib/mirrors.cc - Issue 1691163002: Fix background compilation crashes due to allocation of types in new space. Remove default argument…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/mirrors.cc

Issue 1691163002: Fix background compilation crashes due to allocation of types in new space. Remove default argument… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: e Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | runtime/lib/object.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "lib/mirrors.h"	5 #include "lib/mirrors.h"

6	6

7 #include "lib/invocation_mirror.h"	7 #include "lib/invocation_mirror.h"

8 #include "vm/bootstrap_natives.h"	8 #include "vm/bootstrap_natives.h"

9 #include "vm/class_finalizer.h"	9 #include "vm/class_finalizer.h"

10 #include "vm/compiler.h"	10 #include "vm/compiler.h"

(...skipping 2068 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2079 GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));	2079 GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));

2080 const Field& field = Field::Handle(ref.GetFieldReferent());	2080 const Field& field = Field::Handle(ref.GetFieldReferent());

2081 GET_NATIVE_ARGUMENT(AbstractType, instantiator, arguments->NativeArgAt(1));	2081 GET_NATIVE_ARGUMENT(AbstractType, instantiator, arguments->NativeArgAt(1));

2082 const AbstractType& type = AbstractType::Handle(field.type());	2082 const AbstractType& type = AbstractType::Handle(field.type());

2083 return InstantiateType(type, instantiator);	2083 return InstantiateType(type, instantiator);

2084 }	2084 }

2085	2085

2086 DEFINE_NATIVE_ENTRY(TypeMirror_subtypeTest, 2) {	2086 DEFINE_NATIVE_ENTRY(TypeMirror_subtypeTest, 2) {

2087 GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));	2087 GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));

2088 GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));	2088 GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));

2089 return Bool::Get(a.IsSubtypeOf(b, NULL)).raw();	2089 return Bool::Get(a.IsSubtypeOf(b, NULL, NULL, Heap::kNew)).raw();

2090 }	2090 }

2091	2091

2092	2092

2093 } // namespace dart	2093 } // namespace dart

OLD	NEW