Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1691053002: Cannot do simplified layout on an object that contains a column-spanner. (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cannot do simplified layout on an object that contains a column-spanner. Introducing LayoutFlowThread::canSkipLayout(). The implementation of this method needed two pieces of simple functionality that already existed in other methods. Refactored them into separate functions, instead of duplicating the code. BUG=512757 Committed: https://crrev.com/99068e814976797223caf3b76b69ce2d5c195686 Cr-Commit-Position: refs/heads/master@{#375071}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-11 20:34:38 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 10 months ago (2016-02-12 01:00:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691053002/1
4 years, 10 months ago (2016-02-12 01:04:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 01:15:19 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:40:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99068e814976797223caf3b76b69ce2d5c195686
Cr-Commit-Position: refs/heads/master@{#375071}

Powered by Google App Engine
This is Rietveld 408576698