third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h - Issue 1691053002: Cannot do simplified layout on an object that contains a column-spanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1691053002: Cannot do simplified layout on an object that contains a column-spanner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFlowThread.h ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

index 65ee5a44bbc67c7c1921373629f9029e5bb8e352..7b68e77411372a3770e4174dbc9081fe0c7b2659 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

@@ -237,6 +237,7 @@ private:

void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;

void updateLogicalWidth() override;

void contentWasLaidOut(LayoutUnit logicalBottomInFlowThreadAfterPagination) override;

+ bool canSkipLayout(const LayoutBox&) const override;

// The last set we worked on. It's not to be used as the "current set". The concept of a

// "current set" is difficult, since layout may jump back and forth in the tree, due to wrong