Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1690973002: [interpreter] Correctly thread through catch prediction. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy, Yang
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Correctly thread through catch prediction. This change correctly sets the {CatchPrediction} field in exception handler tables for bytecode and optimized code. It also adds tests independent of promise handling for this prediction, to ensure all our backends are in sync on their prediction. R=rmcilroy@chromium.org,yangguo@chromium.org TEST=mjsunit/compiler/debug-catch-prediction BUG=v8:4674 LOG=n Committed: https://crrev.com/ba55f5594cb0b4a1a1e9b35d87fe54afe2d93f3b Cr-Commit-Position: refs/heads/master@{#33906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -10 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M src/interpreter/control-flow-builders.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/interpreter/control-flow-builders.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/debug-catch-prediction.js View 1 chunk +143 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Starzinger
Ross: PTAL especially at interpreter pieces. Yang: PTAL especially at the new test cases.
4 years, 10 months ago (2016-02-11 14:49:38 UTC) #1
Yang
On 2016/02/11 14:49:38, Michael Starzinger wrote: > Ross: PTAL especially at interpreter pieces. > Yang: ...
4 years, 10 months ago (2016-02-11 14:58:45 UTC) #5
rmcilroy
Awesome, lgtm, thanks!
4 years, 10 months ago (2016-02-11 15:33:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690973002/1
4 years, 10 months ago (2016-02-11 15:44:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 16:12:54 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ba55f5594cb0b4a1a1e9b35d87fe54afe2d93f3b Cr-Commit-Position: refs/heads/master@{#33906}
4 years, 10 months ago (2016-02-11 16:15:46 UTC) #12
adamk
4 years, 10 months ago (2016-02-12 00:41:37 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1695613002/ by adamk@chromium.org.

The reason for reverting is: Depends on the reverted
https://codereview.chromium.org/1691723002.

Powered by Google App Engine
This is Rietveld 408576698