[interpreter] Make d8's TryCatch block be verbose.

[interpreter] Make d8's TryCatch block be verbose.

This changes "d8" to no longer report exceptions as being "caught" when
it comes to the catch prediction mechanism in our debugger. This treats
scripts as being truly top-level when it comes to exception handling and
will allow us to properly test the catch prediction mechanism using just
mjsunit tests alone.

R=yangguo@chromium.org
BUG=v8:4674
LOG=n

Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45
Cr-Commit-Position: refs/heads/master@{#33898}

[Michael Starzinger, 2016-02-11 12:35:19]

This will require adaptation of expected output for the "messages" test suite.
But IMHO, the new output actually makes more sense, as it reports properly
prefixed exceptions now. WDYT?

[Yang, 2016-02-11 12:50:47]

On 2016/02/11 12:35:19, Michael Starzinger wrote:
> This will require adaptation of expected output for the "messages" test suite.
> But IMHO, the new output actually makes more sense, as it reports properly
> prefixed exceptions now. WDYT?

lgtm once we figure out the message error line number.

[Michael Starzinger, 2016-02-11 13:20:18]

PTAL. I found a way to make this work without having to adapt all of the
"message" expectations. The new patch set puts d8 fully in charge of formatting
the output again (as it was before), by making sure our
MessageHandler::DefaultMessageReport is not called.

[Yang, 2016-02-11 13:57:41]

On 2016/02/11 13:20:18, Michael Starzinger wrote:
> PTAL. I found a way to make this work without having to adapt all of the
> "message" expectations. The new patch set puts d8 fully in charge of
formatting
> the output again (as it was before), by making sure our
> MessageHandler::DefaultMessageReport is not called.

Still lgtm. For the record the nop message handler does not apply for additional
isolates created for workers and isolate test

[Michael Starzinger, 2016-02-11 14:01:45]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-02-11 14:01:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691723002/40001

[commit-bot: I haz the power, 2016-02-11 14:04:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-11 14:05:30]

Description was changed from

==========
[interpreter] Make d8's TryCatch block be verbose.

This changes "d8" to no longer report exceptions as being "caught" when
it comes to the catch prediction mechanism in our debugger. This treats
scripts as being truly top-level when it comes to exception handling and
will allow us to properly test the catch prediction mechanism using just
mjsunit tests alone.

R=yangguo@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Make d8's TryCatch block be verbose.

This changes "d8" to no longer report exceptions as being "caught" when
it comes to the catch prediction mechanism in our debugger. This treats
scripts as being truly top-level when it comes to exception handling and
will allow us to properly test the catch prediction mechanism using just
mjsunit tests alone.

R=yangguo@chromium.org
BUG=v8:4674
LOG=n

Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45
Cr-Commit-Position: refs/heads/master@{#33898}
==========

[commit-bot: I haz the power, 2016-02-11 14:05:30]

Patchset 3 (id:??) landed as
https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45
Cr-Commit-Position: refs/heads/master@{#33898}

[Michael Achenbach, 2016-02-11 23:10:28]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1694523003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert. Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20...

Somehow
https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d...
seems to hide it again and then
https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b25011...
lets it show up again.

Reproduced locally..