Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1690913002: [interpreter] Deprecate DeleteLookupSlot bytecode. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Deprecate DeleteLookupSlot bytecode. This replaces the bytecode in question with a runtime call within the bytecode stream. The tradeoff is to safe one bytecode opcode for more expensive encoding of lookup slot deletion. R=rmcilroy@chromium.org Committed: https://crrev.com/2749ebba33620eb679d0ea9804daa39513b0de14 Cr-Commit-Position: refs/heads/master@{#33907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -46 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +15 lines, -13 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/unittests/interpreter/bytecodes-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Ross: PTAL. Benedikt: FYI.
4 years, 10 months ago (2016-02-11 12:39:39 UTC) #2
rmcilroy
LGTM
4 years, 10 months ago (2016-02-11 15:39:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690913002/1
4 years, 10 months ago (2016-02-11 15:52:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 16:16:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 16:18:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2749ebba33620eb679d0ea9804daa39513b0de14
Cr-Commit-Position: refs/heads/master@{#33907}

Powered by Google App Engine
This is Rietveld 408576698