test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 1690913002: [interpreter] Deprecate DeleteLookupSlot bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 1690913002: [interpreter] Deprecate DeleteLookupSlot bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index e8ab446e822a88861ebb181a6887d6f36b97a365..3bffa900356daa6e59f65d6c87f6542512120a4d 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -133,9 +133,7 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

builder.LogicalNot().TypeOf();

// Emit delete

- builder.Delete(reg, LanguageMode::SLOPPY)

- .Delete(reg, LanguageMode::STRICT)

- .DeleteLookupSlot();

+ builder.Delete(reg, LanguageMode::SLOPPY).Delete(reg, LanguageMode::STRICT);

// Emit new.

builder.New(reg, reg, 0);