Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1506)

Unified Diff: runtime/vm/intermediate_language.h

Issue 1690903003: Remove support for Javascript warnings in the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index f4664dc04a9b53e98d41febfdb77c6c5d5bf15ea..886a2f5977fc2c353098a984722f62bd755456df 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -17,8 +17,6 @@
namespace dart {
-DECLARE_FLAG(bool, throw_on_javascript_int_overflow);
-
class BitVector;
class BlockEntryInstr;
class BoxIntegerInstr;
@@ -6829,7 +6827,7 @@ class UnaryMintOpInstr : public UnaryIntegerOpInstr {
}
virtual bool CanDeoptimize() const {
- return FLAG_throw_on_javascript_int_overflow;
+ return false;
}
virtual CompileType ComputeType() const;
@@ -7089,8 +7087,7 @@ class BinaryMintOpInstr : public BinaryIntegerOpInstr {
}
virtual bool CanDeoptimize() const {
- return FLAG_throw_on_javascript_int_overflow
- || (can_overflow() && ((op_kind() == Token::kADD) ||
+ return (can_overflow() && ((op_kind() == Token::kADD) ||
(op_kind() == Token::kSUB)))
|| (op_kind() == Token::kMUL); // Deopt if inputs are not int32.
}
@@ -7125,8 +7122,7 @@ class ShiftMintOpInstr : public BinaryIntegerOpInstr {
}
virtual bool CanDeoptimize() const {
- return FLAG_throw_on_javascript_int_overflow
- || has_shift_count_check()
+ return has_shift_count_check()
|| (can_overflow() && (op_kind() == Token::kSHL));
}
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698