Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1690823003: Move ScriptForbiddenScope assert to isolate's BeforeCallEnteredCallback. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptForbiddenScope assert to isolate's BeforeCallEnteredCallback. BUG=585949 Committed: https://crrev.com/90ad66113c4e625c5b28f50c0cbf08e5578ae08a Cr-Commit-Position: refs/heads/master@{#376812}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 1 4 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look? This is a blink-side patch for https://codereview.chromium.org/1689863002/.
4 years, 10 months ago (2016-02-11 01:32:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-22 14:10:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690823003/20001
4 years, 10 months ago (2016-02-22 20:11:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-22 21:46:41 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 21:48:44 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/90ad66113c4e625c5b28f50c0cbf08e5578ae08a
Cr-Commit-Position: refs/heads/master@{#376812}

Powered by Google App Engine
This is Rietveld 408576698