Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h

Issue 1690823003: Move ScriptForbiddenScope assert to isolate's BeforeCallEnteredCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h b/third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h
index ff3c133f74e853e9a566871cc267e29db6090b09..dd9a51fb354f2ce33937587882c6ff849a61cb30 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h
@@ -33,7 +33,6 @@
#include "bindings/core/v8/V8PerIsolateData.h"
#include "core/CoreExport.h"
-#include "platform/ScriptForbiddenScope.h"
#include "wtf/Noncopyable.h"
#include <v8.h>
@@ -62,7 +61,6 @@ public:
explicit V8RecursionScope(v8::Isolate* isolate)
: m_isolate(isolate)
{
- RELEASE_ASSERT(!ScriptForbiddenScope::isScriptForbidden());
V8PerIsolateData::from(m_isolate)->incrementRecursionLevel();
// If you want V8 to autorun microtasks, this class needs to have a
// v8::Isolate::SuppressMicrotaskExecutionScope member.
@@ -96,7 +94,6 @@ public:
: m_isolate(isolate)
#endif
{
- RELEASE_ASSERT(!ScriptForbiddenScope::isScriptForbidden());
#if ENABLE(ASSERT)
V8PerIsolateData::from(m_isolate)->incrementInternalScriptRecursionLevel();
#endif
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698