Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1690583002: Clean up comments in SkSwizzler (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/codec/SkSwizzler.cpp View 1 chunk +5 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (4 generated)
msarett
https://codereview.chromium.org/1690583002/diff/1/src/codec/SkSwizzler.cpp File src/codec/SkSwizzler.cpp (left): https://codereview.chromium.org/1690583002/diff/1/src/codec/SkSwizzler.cpp#oldcode932 src/codec/SkSwizzler.cpp:932: SkASSERT(sampleX > 0); // Surely there is an upper ...
4 years, 10 months ago (2016-02-10 13:42:59 UTC) #3
scroggo
lgtm https://codereview.chromium.org/1690583002/diff/1/src/codec/SkSwizzler.cpp File src/codec/SkSwizzler.cpp (left): https://codereview.chromium.org/1690583002/diff/1/src/codec/SkSwizzler.cpp#oldcode932 src/codec/SkSwizzler.cpp:932: SkASSERT(sampleX > 0); // Surely there is an ...
4 years, 10 months ago (2016-02-10 16:06:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690583002/1
4 years, 10 months ago (2016-02-10 16:10:58 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:39:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9972c424ea5eaa2d78e06ae068abc86fd408e0e3

Powered by Google App Engine
This is Rietveld 408576698