Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: ui/views/widget/widget_interactive_uitest.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/widget_interactive_uitest.cc
diff --git a/ui/views/widget/widget_interactive_uitest.cc b/ui/views/widget/widget_interactive_uitest.cc
index 071be4550b91d5e1dbe889a3e44fc418ea11c7bb..e09726b84bb73e077f1a752a65ba5494f893c8d7 100644
--- a/ui/views/widget/widget_interactive_uitest.cc
+++ b/ui/views/widget/widget_interactive_uitest.cc
@@ -317,7 +317,7 @@ class WidgetTestInteractive : public WidgetTest {
TEST_F(WidgetTestInteractive, DesktopNativeWidgetAuraActivationAndFocusTest) {
// Create widget 1 and expect the active window to be its window.
View* focusable_view1 = new View;
- focusable_view1->SetFocusable(true);
+ focusable_view1->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
Widget* widget1 = CreateWidget();
widget1->GetContentsView()->AddChildView(focusable_view1);
widget1->Show();
@@ -639,14 +639,14 @@ TEST_F(WidgetTestInteractive, CheckResizeControllerEvents) {
TEST_F(WidgetTestInteractive, ViewFocusOnWidgetActivationChanges) {
Widget* widget1 = CreateTopLevelPlatformWidget();
View* view1 = new View;
- view1->SetFocusable(true);
+ view1->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
widget1->GetContentsView()->AddChildView(view1);
Widget* widget2 = CreateTopLevelPlatformWidget();
View* view2a = new View;
View* view2b = new View;
- view2a->SetFocusable(true);
- view2b->SetFocusable(true);
+ view2a->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
+ view2b->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
widget2->GetContentsView()->AddChildView(view2a);
widget2->GetContentsView()->AddChildView(view2b);
@@ -688,7 +688,8 @@ TEST_F(WidgetTestInteractive, ViewFocusOnHWNDEnabledChanges) {
widget->SetContentsView(new View);
for (size_t i = 0; i < 2; ++i) {
widget->GetContentsView()->AddChildView(new View);
- widget->GetContentsView()->child_at(i)->SetFocusable(true);
+ widget->GetContentsView()->child_at(i)->SetFocusBehavior(
+ views::View::FocusBehavior::ALWAYS);
}
widget->Show();
@@ -1087,7 +1088,7 @@ TEST_F(WidgetTestInteractive, DisableViewDoesNotActivateWidget) {
widget1.Init(params1);
View* view1 = new View();
- view1->SetFocusable(true);
+ view1->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
widget1.GetRootView()->AddChildView(view1);
ActivateSync(&widget1);
@@ -1105,7 +1106,7 @@ TEST_F(WidgetTestInteractive, DisableViewDoesNotActivateWidget) {
widget2.Init(params2);
View* view2 = new View();
- view2->SetFocusable(true);
+ view2->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
widget2.GetRootView()->AddChildView(view2);
ActivateSync(&widget2);
@@ -1266,7 +1267,7 @@ TEST_F(WidgetTestInteractive, InitialFocus) {
// focusable subview).
Widget* toplevel(CreateTopLevelPlatformWidget());
View* view = new View;
- view->SetFocusable(true);
+ view->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
toplevel->GetContentsView()->AddChildView(view);
ShowSync(toplevel);

Powered by Google App Engine
This is Rietveld 408576698