Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index 8fc4aa3cf7651c320322385ce240c42e48924785..77206075d14e830557f0fdfd37ca423567963bbf 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -1189,7 +1189,7 @@ TEST_F(WidgetTest, KeyboardInputEvent) {
TEST_F(WidgetTest, DISABLED_FocusChangesOnBubble) {
// Create a widget, show and activate it and focus the contents view.
View* contents_view = new View;
- contents_view->SetFocusable(true);
+ contents_view->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
Widget widget;
Widget::InitParams init_params =
CreateParams(Widget::InitParams::TYPE_WINDOW_FRAMELESS);
@@ -1209,7 +1209,7 @@ TEST_F(WidgetTest, DISABLED_FocusChangesOnBubble) {
// Show a bubble.
BubbleDelegateView* bubble_delegate_view =
new BubbleDelegateView(contents_view, BubbleBorder::TOP_LEFT);
- bubble_delegate_view->SetFocusable(true);
+ bubble_delegate_view->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
BubbleDelegateView::CreateBubble(bubble_delegate_view)->Show();
bubble_delegate_view->RequestFocus();
@@ -1351,7 +1351,7 @@ void DesktopAuraTestValidPaintWidget::InitForTest(InitParams init_params) {
Init(init_params);
View* contents_view = new View;
- contents_view->SetFocusable(true);
+ contents_view->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
SetContentsView(contents_view);
Show();

Powered by Google App Engine
This is Rietveld 408576698