ui/views/controls/button/custom_button.h - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/custom_button.h

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/custom_button.h

diff --git a/ui/views/controls/button/custom_button.h b/ui/views/controls/button/custom_button.h

index fa0a215d1007b47ea0078735afccd6b8d0d6bae2..6e7c6762132ef9abfd090f6596aa1bc4b84f3f72 100644

--- a/ui/views/controls/button/custom_button.h

+++ b/ui/views/controls/button/custom_button.h

@@ -19,8 +19,8 @@ class InkDropDelegate;

// A button with custom rendering. The base of ImageButton and LabelButton.

// Note that this type of button is not focusable by default and will not be

-// part of the focus chain. Call SetFocusable(true) to make it part of the

-// focus chain.

+// part of the focus chain, unless in accessibility mode. Call

+// SetFocusBehavior(FocusBehavior::CONTROL) to make it part of the focus chain.

class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {

public:

// An enum describing the events on which a button should notify its listener.